Fix OS command and argument injection in C# and ASP.NET Core
============================================================

Start the process with ProcessStartInfo.ArgumentList and UseShellExecute =
false - psi.ArgumentList.Add("--"); psi.ArgumentList.Add(name) - so no shell
parses the arguments, and the '--' makes a leading-dash operand data, not an
option. Never run /bin/sh -c with a built string. Choose a format from an
allowlist, never from free text.

Page: https://softwaresecurity.com/fix/command-injection/csharp-aspnetcore/

What is in this archive
-----------------------
command-injection/csharp-aspnetcore/   the project: three implementations of the same code and one test suite
  src/Greet/impl/VulnerableGreetService.cs   (vulnerable)
  src/Greet/impl/FixedGreetService.cs   (fixed)
  src/Greet/impl/WrongGreetService.cs   (a plausible fix that still fails)
run-all.mjs   runs the tests in all three modes and checks the results (Node.js only)
LICENSE-CODE.txt

Run it
------
  Tested with .NET 10.0.12 (SDK 10.0.112). run-all.mjs needs Node.js 22 or
  later. Supported versions: https://softwaresecurity.com/fix/versions/

  From the command-injection/csharp-aspnetcore folder, install the dependencies
  once (this needs network access):

    dotnet restore tests/Greet.Tests --locked-mode

  Then run the tests. IMPL chooses the implementation the tests load:

    # every test passes
    IMPL=fixed dotnet test --project tests/Greet.Tests --no-restore --results-directory reports --report-xunit-junit --report-xunit-junit-filename junit.xml
    # an exploit test fails
    IMPL=vulnerable dotnet test --project tests/Greet.Tests --no-restore --results-directory reports --report-xunit-junit --report-xunit-junit-filename junit.xml
    # a test fails
    IMPL=wrong dotnet test --project tests/Greet.Tests --no-restore --results-directory reports --report-xunit-junit --report-xunit-junit-filename junit.xml

  The JUnit report is written to reports/junit.xml. To run all three modes and
  check the results in one step, run the harness from this top folder (it needs
  only Node.js; --install runs the install step first):

    node run-all.mjs --install command-injection/csharp-aspnetcore
    node run-all.mjs command-injection/csharp-aspnetcore

Verified
--------
  11 October 2026 on macOS 27.0 (Darwin 27.0.0, arm64), with dotnetSdk 10.0.112,
  dotnetRuntime 10.0.12, mvcTesting 10.0.12, xunitV3 4.0.1, shell /bin/sh
  (dash-compatible POSIX shell). Versions and results hold for that date: run
  the tests with your own versions before relying on the fix.

Licence
-------
  The code is MIT licensed (LICENSE-CODE.txt). The page text is CC BY 4.0.
